jacob.eva/arduino-esp32
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix WiFiClient.connected() (#3654)

Browse Source 
WiFiClient.connected() was hanging thinking there was still a connection when the remote had already closed. The one-liner in this patch addresses recv() returning 0 and errno==128. I couldn't find the corresponding errno for 128 but its caught by the case statement which includes EPIPE, ENOTCONN, ECONNRESET and ECONNABORTED so I assume its one of those. Broken pipe maybe?
```c
[D][WiFiClient.cpp:511] connected(): Disconnected: RES: 0, ERR: 128
```
EDIT: added comment to reflect that recv() can set errno when it returns 0.
This commit is contained in:
Mark D 2020-01-21 05:36:03 -05:00 committed by Me No Dev
parent ed59ae6482
commit bb0a194bb7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/WiFi/src/WiFiClient.cpp
View File

@ -495,8 +495,8 @@ uint8_t WiFiClient::connected()
int res = recv(fd(), &dummy, 0, MSG_DONTWAIT); int res = recv(fd(), &dummy, 0, MSG_DONTWAIT);
// avoid unused var warning by gcc // avoid unused var warning by gcc
(void)res; (void)res;
// recv only sets errno if res is -1 // recv only sets errno if res is <= 0
if (res < 0){ if (res <= 0){
switch (errno) { switch (errno) {
case EWOULDBLOCK: case EWOULDBLOCK:
case ENOENT: //caused by vfs case ENOENT: //caused by vfs