jacob.eva/arduino-esp32
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Wire endTransmission() fix for issue #1725 (#1888)

Browse Source 
* removed uint8_t Wire.endTransmission(uint8_t sendStop)

Having both endTransmission(bool) and endTransmission(uint8_t) creates problems.
There is no need for endTransmission(uint8_t)
endTransmission(1) and endTransmission(0) works with endTransmission(bool).
Removing endTransmission(uint8_t) allows the ESP32 code to be compatible with
all the other Arduino cores by allowing endTransmission(1) and endTranmission(0)
to work as it does on all the other cores.

* Wire library version bump for endTransmission() update
This commit is contained in:
bperrybap 2018-11-19 09:40:14 -06:00 committed by Me No Dev
parent f12df4c719
commit deaf339bde
3 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/Wire/library.properties
View File

@ -1,5 +1,5 @@
name=Wire name=Wire
version=1.0 version=1.0.1
author=Hristo Gochkov author=Hristo Gochkov
maintainer=Hristo Gochkov <hristo@espressif.com> maintainer=Hristo Gochkov <hristo@espressif.com>
sentence=Allows the communication between devices or sensors connected via Two Wire Interface Bus. For esp8266 boards. sentence=Allows the communication between devices or sensors connected via Two Wire Interface Bus. For esp8266 boards.

5
libraries/Wire/src/Wire.cpp
View File

@ -308,11 +308,6 @@ uint8_t TwoWire::endTransmission(void)
return endTransmission(true); return endTransmission(true);
} }
uint8_t TwoWire::endTransmission(uint8_t sendStop)
{
return endTransmission(static_cast<bool>(sendStop));
}
/* stickbreaker Nov2017 better error reporting /* stickbreaker Nov2017 better error reporting
*/ */
uint8_t TwoWire::lastError() uint8_t TwoWire::lastError()

1
libraries/Wire/src/Wire.h
View File

@ -87,7 +87,6 @@ public:
void beginTransmission(int address); void beginTransmission(int address);
uint8_t endTransmission(bool sendStop); uint8_t endTransmission(bool sendStop);
uint8_t endTransmission(uint8_t sendStop);
uint8_t endTransmission(void); uint8_t endTransmission(void);
uint8_t requestFrom(uint16_t address, uint8_t size, bool sendStop); uint8_t requestFrom(uint16_t address, uint8_t size, bool sendStop);