jacob.eva/monerowp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check if payment id is set first

Browse Source 
Check that a payment id is set before verifying that the merchant owns that output instead of just checking every output in a block
This commit is contained in:
cryptochangements34 2018-01-23 21:47:49 -06:00 committed by GitHub
parent 5da38e31ca
commit 590779c263
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
monero/include/monero_payments.php
View File

@ -312,10 +312,15 @@ class Monero_Gateway extends WC_Payment_Gateway
} }
$uri = "monero:$address?amount=$amount?payment_id=$payment_id"; $uri = "monero:$address?amount=$amount?payment_id=$payment_id";
if($this->verify_non_rpc($payment_id, $amount_xmr2, $order_id) == false); $this->verify_non_rpc($payment_id, $amount_xmr2, $order_id);
if($this->confirmed == false)
{ {
echo "<h4> We are waiting for your transaction to be confirmed </h4>"; echo "<h4> We are waiting for your transaction to be confirmed </h4>";
} }
if($this->confirmed)
{
echo "<h4> Your transaction has been successfully confirmed! </h4>";
}
echo " echo "
<head> <head>
@ -608,12 +613,15 @@ class Monero_Gateway extends WC_Payment_Gateway
while($i <= $tx_count) while($i <= $tx_count)
{ {
$tx_hash = $txs_from_block[$i]['tx_hash']; $tx_hash = $txs_from_block[$i]['tx_hash'];
$result = $tools->check_tx($tx_hash, $this->address, $this->viewKey); if(strlen($txs_from_block[$i]['payment_id']) != 0)
if($result)
{ {
$output_found = $result; $result = $tools->check_tx($tx_hash, $this->address, $this->viewKey);
$block_index = $i; if($result)
$i = $tx_count; // finish loop {
$output_found = $result;
$block_index = $i;
$i = $tx_count; // finish loop
}
} }
$i++; $i++;
} }