jacob.eva/arduino-esp32
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Error Handling for Window10 without CygWin (#117)

Browse Source 
Added an Exception handling to the offending urlretrieve() call for the issue #108 https://github.com/espressif/arduino-esp32/issues/108

It's not really a fix but the failure message is much more elegant than the initial stack trace as it hints at the solution to the setup problem rather than confusing the user into Windows problems.
This commit is contained in:
tobozo 2017-01-05 14:02:56 +01:00 committed by Me No Dev
parent 8b96b1a5f4
commit b5858c1904
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/get.py
View File

@ -80,7 +80,15 @@ def get_tool(tool):
if 'CYGWIN_NT' in sys_name: if 'CYGWIN_NT' in sys_name:
urlretrieve(url, local_path, report_progress,context=ctx) urlretrieve(url, local_path, report_progress,context=ctx)
else: else:
urlretrieve(url, local_path, report_progress) try:
urlretrieve(url, local_path, report_progress)
except Exception,e:
print()
print("!!! TLS Failed !!! Download the following file manually and put it in the 'dist' folder:")
print(url)
print("... then run this script again.")
print()
raise Exception('Aborting')
sys.stdout.write("\rDone\n") sys.stdout.write("\rDone\n")
sys.stdout.flush() sys.stdout.flush()
else: else: